From a959f204bde66aba3a50a9393e6733803877acc6 Mon Sep 17 00:00:00 2001
From: JCEEE <0xjceee@proton.me>
Date: Fri, 4 Sep 2026 10:22:51 +0100
Subject: [PATCH] cleanup period confusion

---
 frontend/src/routes/admin/+page.server.ts |  4 +--
 frontend/src/routes/admin/+page.svelte    | 33 +++++++++++++----------
 2 files changed, 21 insertions(+), 16 deletions(-)

diff --git a/frontend/src/routes/admin/+page.server.ts b/frontend/src/routes/admin/+page.server.ts
index a5ab2ad..1d7901f 100644
--- a/frontend/src/routes/admin/+page.server.ts
+++ b/frontend/src/routes/admin/+page.server.ts
@@ -277,7 +277,7 @@ export const actions: Actions = {
 					rewardType: (fd.get('rewardType') as string) || 'points',
 					rewardValue: (fd.get('rewardValue') as string) || '',
 					criteriaValue: Number(fd.get('criteriaValue') || 0),
-					period: (fd.get('period') as string) || 'weekly'
+					period: (fd.get('period') as string) || ''
 				});
 			}
 			return { success: true };
@@ -321,7 +321,7 @@ export const actions: Actions = {
 					rewardType: (fd.get('rewardType') as string) || 'points',
 					rewardValue: (fd.get('rewardValue') as string) || '',
 					criteriaValue: Number(fd.get('criteriaValue') || 0),
-					period: (fd.get('period') as string) || 'weekly'
+					period: (fd.get('period') as string) || ''
 				});
 			}
 			return { success: true };
diff --git a/frontend/src/routes/admin/+page.svelte b/frontend/src/routes/admin/+page.svelte
index 94c2d3d..658ca0e 100644
--- a/frontend/src/routes/admin/+page.svelte
+++ b/frontend/src/routes/admin/+page.svelte
@@ -45,7 +45,7 @@
 		rewardType: 'points',
 		rewardValue: '',
 		criteriaValue: 0,
-		period: 'weekly'
+		period: 'daily'
 	};
 	let tplVals = $state({ ...blankTpl });
 
@@ -73,7 +73,7 @@
 			rewardType: rec.rewardType || 'points',
 			rewardValue: rec.rewardValue ?? '',
 			criteriaValue: rec.criteriaValue ?? 0,
-			period: rec.period || 'weekly'
+			period: rec.period || ''
 		};
 		showTplModal = true;
 	}
@@ -554,18 +554,23 @@
 									Reward Value
 									<input name="rewardValue" bind:value={tplVals.rewardValue} />
 								</label>
-								<label>
-									Target Value
-									<input type="number" name="criteriaValue" bind:value={tplVals.criteriaValue} />
-								</label>
-								<label>
-									Period
-									<select name="period" bind:value={tplVals.period}>
-										<option value="daily">Daily</option>
-										<option value="weekly">Weekly</option>
-										<option value="monthly">Monthly</option>
-									</select>
-								</label>
+								{#if tplVals.bonusType !== 'manual'}
+									<label>
+										Target Value
+										<input type="number" name="criteriaValue" bind:value={tplVals.criteriaValue} />
+									</label>
+								{/if}
+								{#if tplVals.bonusType === 'manual'}
+									<label>
+										Period
+										<select name="period" bind:value={tplVals.period}>
+											<option value="">Unlimited</option>
+											<option value="daily">Daily</option>
+											<option value="weekly">Weekly</option>
+											<option value="monthly">Monthly</option>
+										</select>
+									</label>
+								{/if}
 
 							{/if}